security: block CGNAT range and guard browser_open_url - #353
Merged
Conversation
Follow up to #290. Add RFC 6598 shared space (100.64.0.0/10, used by Tailscale) to the address guard, and run the same guard on the Playwright browser_open_url before navigating.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #290, covering the two gaps noted there.
The address guard now blocks 100.64.0.0/10 (RFC 6598 shared address space). Python's is_private misses it, but Tailscale and some carrier grade NAT / pod networks hand out internal hosts there, so it is the same reachability class as RFC1918.
browser_open_url (the Playwright tool) now runs the same guard before navigating. It is approval gated, so this is defense in depth rather than the primary control, and it checks the initial model supplied URL only (redirects the browser follows internally are not hop checked).